Fix. Settings. Improve psc detect in plugins list. - #720
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves plugin vulnerability/PSC detection by deriving a reliable plugin slug from the plugin file path (folder) and/or TextDomain when the WordPress.org slug is missing (common on the installed plugins page when Plugin URI is custom).
Changes:
- Update
VulnerabilityAlarm::getSafePlugins()to pass the plugin file path intogetPluginSlug()so slug resolution can fall back to the folder name. - Update the admin “installed plugins” row hook to use
VulnerabilityAlarm::getPluginSlug()instead ofsanitize_title($plugin_data['Name']). - Add PHPUnit tests covering slug fallback behavior and version bound matching.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/lib/CleantalkSP/VulnerabilityAlarm/VulnerabilityAlarmTest.php |
Adds regression tests for slug resolution (folder/TextDomain) and version matching. |
lib/CleantalkSP/SpbctWP/VulnerabilityAlarm/VulnerabilityAlarm.php |
Passes plugin file path into slug resolution when building/checking the safe plugins list. |
inc/spbc-admin.php |
Uses the improved slug resolution on the plugins list to enable checks even when WP.org slugs are absent. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task https://app.doboard.com/1/task/55550